[openwrt/openwrt] treewide: do not quote compatible in shell scripts

LEDE Commits lede-commits at lists.infradead.org
Sun Jun 6 12:38:51 PDT 2021


adrian pushed a commit to openwrt/openwrt.git, branch master:
https://git.openwrt.org/2341c621e42e5fadd6b3205365fb448e44bcbbe0

commit 2341c621e42e5fadd6b3205365fb448e44bcbbe0
Author: Adrian Schmutzler <freifunk at adrianschmutzler.de>
AuthorDate: Sun Jun 6 19:17:47 2021 +0200

    treewide: do not quote compatible in shell scripts
    
    The compatible is a literal string without any problematic
    characters, so there is no reason to quote it.
    
    Signed-off-by: Adrian Schmutzler <freifunk at adrianschmutzler.de>
---
 .../linux/arc770/base-files/etc/board.d/02_network |  2 +-
 .../kirkwood/base-files/etc/board.d/02_network     | 36 +++++++++++-----------
 .../lib/preinit/05_layerscape_reorder_eth          |  4 +--
 3 files changed, 21 insertions(+), 21 deletions(-)

diff --git a/target/linux/arc770/base-files/etc/board.d/02_network b/target/linux/arc770/base-files/etc/board.d/02_network
index f326f48763..c90f3fb6a6 100644
--- a/target/linux/arc770/base-files/etc/board.d/02_network
+++ b/target/linux/arc770/base-files/etc/board.d/02_network
@@ -7,7 +7,7 @@
 board_config_update
 
 case "$(board_name)" in
-"snps,axs101")
+snps,axs101)
 	ucidef_set_interface_lan "eth0" "dhcp"
 	;;
 esac
diff --git a/target/linux/kirkwood/base-files/etc/board.d/02_network b/target/linux/kirkwood/base-files/etc/board.d/02_network
index c379d13046..694bcaecce 100644
--- a/target/linux/kirkwood/base-files/etc/board.d/02_network
+++ b/target/linux/kirkwood/base-files/etc/board.d/02_network
@@ -10,33 +10,33 @@ board_config_update
 board=$(board_name)
 
 case "$board" in
-"checkpoint,l-50")
+checkpoint,l-50)
 	ucidef_set_interfaces_lan_wan "lan1 lan2 lan3 lan4 lan5 lan6 lan7 lan8 dmz" "eth0"
 	;;
-"cisco,on100")
+cisco,on100)
 	ucidef_set_interface_lan "eth0 eth1"
 	;;
-"cloudengines,pogoe02"|\
-"cloudengines,pogoplugv4"|\
-"globalscale,sheevaplug"|\
-"iom,iconnect-1.1"|\
-"iom,ix2-200"|\
-"raidsonic,ib-nas62x0"|\
-"seagate,blackarmor-nas220"|\
-"seagate,dockstar"|\
-"seagate,goflexhome"|\
-"seagate,goflexnet"|\
-"zyxel,nsa310s")
+cloudengines,pogoe02|\
+cloudengines,pogoplugv4|\
+globalscale,sheevaplug|\
+iom,iconnect-1.1|\
+iom,ix2-200|\
+raidsonic,ib-nas62x0|\
+seagate,blackarmor-nas220|\
+seagate,dockstar|\
+seagate,goflexhome|\
+seagate,goflexnet|\
+zyxel,nsa310s)
 	ucidef_set_interface_lan "eth0" "dhcp"
 	;;
-"linksys,e4200-v2"|\
-"linksys,ea3500"|\
-"linksys,ea4500")
+linksys,e4200-v2|\
+linksys,ea3500|\
+linksys,ea4500)
 	ucidef_set_interfaces_lan_wan "ethernet1 ethernet2 ethernet3 ethernet4" "internet"
 	ucidef_set_interface_macaddr "wan" $( mtd_get_mac_ascii u_env eth1addr )
 	;;
-"zyxel,nsa310b"|\
-"zyxel,nsa325")
+zyxel,nsa310b|\
+zyxel,nsa325)
 	ucidef_set_interface_lan "eth0" "dhcp"
 	ucidef_set_interface_macaddr "lan" $( mtd_get_mac_ascii uboot_env ethaddr )
 	;;
diff --git a/target/linux/layerscape/base-files/lib/preinit/05_layerscape_reorder_eth b/target/linux/layerscape/base-files/lib/preinit/05_layerscape_reorder_eth
index 141aac8a6d..c6b741a5ce 100644
--- a/target/linux/layerscape/base-files/lib/preinit/05_layerscape_reorder_eth
+++ b/target/linux/layerscape/base-files/lib/preinit/05_layerscape_reorder_eth
@@ -6,8 +6,8 @@ reorder_layerscape_interfaces() {
 
 	board=$(cat /tmp/sysinfo/board_name)
 	case "$board" in
-	"traverse,ls1043v" | \
-	"traverse,ls1043s")
+	traverse,ls1043v|\
+	traverse,ls1043s)
 
 		# Reorder ethernet interfaces to match the physical order
 		ip link set eth2 name fm1-mac3



More information about the lede-commits mailing list