[openwrt/openwrt] kernel: ar8216: remove soft_reset

LEDE Commits lede-commits at lists.infradead.org
Wed Jun 2 15:03:04 PDT 2021


blocktrron pushed a commit to openwrt/openwrt.git, branch master:
https://git.openwrt.org/c5a8b85b72c79e302da0297093be329b3216c57b

commit c5a8b85b72c79e302da0297093be329b3216c57b
Author: David Bauer <mail at david-bauer.net>
AuthorDate: Wed Jun 2 23:46:06 2021 +0200

    kernel: ar8216: remove soft_reset
    
    ar8xxx_soft_reset is effectively a NOP function. In the PHY state
    machine, the availability and result of a soft_reset function
    makes no difference for the code flow.
    
    Thus, we can safely remove this method.
    
    Signed-off-by: David Bauer <mail at david-bauer.net>
---
 target/linux/generic/files/drivers/net/phy/ar8216.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/target/linux/generic/files/drivers/net/phy/ar8216.c b/target/linux/generic/files/drivers/net/phy/ar8216.c
index dbcb1c41c4..11cb18e4f3 100644
--- a/target/linux/generic/files/drivers/net/phy/ar8216.c
+++ b/target/linux/generic/files/drivers/net/phy/ar8216.c
@@ -2731,13 +2731,6 @@ ar8xxx_phy_remove(struct phy_device *phydev)
 	ar8xxx_free(priv);
 }
 
-static int
-ar8xxx_phy_soft_reset(struct phy_device *phydev)
-{
-	/* we don't need an extra reset */
-	return 0;
-}
-
 static struct phy_driver ar8xxx_phy_driver[] = {
 	{
 		.phy_id		= 0x004d0000,
@@ -2749,7 +2742,6 @@ static struct phy_driver ar8xxx_phy_driver[] = {
 		.config_init	= ar8xxx_phy_config_init,
 		.config_aneg	= ar8xxx_phy_config_aneg,
 		.read_status	= ar8xxx_phy_read_status,
-		.soft_reset	= ar8xxx_phy_soft_reset,
 		.get_features	= ar8xxx_get_features,
 	}
 };



More information about the lede-commits mailing list