[openwrt/openwrt] dropbear: enable back DROPBEAR_USE_PASSWORD_ENV

LEDE Commits lede-commits at lists.infradead.org
Fri Dec 11 07:58:18 EST 2020


ynezz pushed a commit to openwrt/openwrt.git, branch master:
https://git.openwrt.org/7e122c353ae7f1e5c546ada94b6d2c3025bee0fe

commit 7e122c353ae7f1e5c546ada94b6d2c3025bee0fe
Author: Konstantin Demin <rockdrilla at gmail.com>
AuthorDate: Wed Nov 25 01:54:05 2020 +0300

    dropbear: enable back DROPBEAR_USE_PASSWORD_ENV
    
    this option was disabled in 2011 and these long nine years showed us that change was definitely wrong.
    
    binary size cost is much less than 1k.
    
    tested on ath79/generic:
      bin: 215128 -> 215128 (no change)
      ipk: 111108 -> 111183 (+75b)
    
    Fixes: 3c801b3dc0359 ("tune some more options by default to decrease size")
    Signed-off-by: Konstantin Demin <rockdrilla at gmail.com>
---
 package/network/services/dropbear/Makefile | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/package/network/services/dropbear/Makefile b/package/network/services/dropbear/Makefile
index 8520426382..727f1c16b0 100644
--- a/package/network/services/dropbear/Makefile
+++ b/package/network/services/dropbear/Makefile
@@ -126,8 +126,7 @@ define Build/Configure
 		$(PKG_BUILD_DIR)/sysoptions.h
 
 	# disable legacy/unsafe methods and unused functionality
-	for OPTION in INETD_MODE DROPBEAR_CLI_NETCAT \
-	DROPBEAR_DSS DROPBEAR_USE_PASSWORD_ENV DO_MOTD ; do \
+	for OPTION in INETD_MODE DROPBEAR_CLI_NETCAT DROPBEAR_DSS DO_MOTD ; do \
 		echo "#define $$$$OPTION 0" >> \
 			$(PKG_BUILD_DIR)/localoptions.h; \
 	done



More information about the lede-commits mailing list