[openwrt/openwrt] realtek: Add missing case in switch statement
LEDE Commits
lede-commits at lists.infradead.org
Fri Dec 11 07:58:17 EST 2020
ynezz pushed a commit to openwrt/openwrt.git, branch master:
https://git.openwrt.org/561bfc96f9bb3303791f6620a958d02167abed0f
commit 561bfc96f9bb3303791f6620a958d02167abed0f
Author: Rafał Mikrut <mikrutrafal at protonmail.com>
AuthorDate: Tue Dec 8 22:01:14 2020 +0100
realtek: Add missing case in switch statement
Cppcheck shows here duplicated break.
Code `state->speed = SPEED_1000;` will be never executed because above
it there is break statement.
Almost identical statement is placed in another realtek driver
https://github.com/openwrt/openwrt/blob/18a53d43d646290053eff4736ec852efcf6bf510/target/linux/realtek/files-5.4/drivers/net/dsa/rtl83xx/dsa.c#L286-L294
Signed-off-by: Rafał Mikrut <mikrutrafal at protonmail.com>
---
target/linux/realtek/files-5.4/drivers/net/ethernet/rtl838x_eth.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/target/linux/realtek/files-5.4/drivers/net/ethernet/rtl838x_eth.c b/target/linux/realtek/files-5.4/drivers/net/ethernet/rtl838x_eth.c
index d53d5dec12..fec842674e 100644
--- a/target/linux/realtek/files-5.4/drivers/net/ethernet/rtl838x_eth.c
+++ b/target/linux/realtek/files-5.4/drivers/net/ethernet/rtl838x_eth.c
@@ -986,6 +986,7 @@ static int rtl838x_mac_pcs_get_state(struct phylink_config *config,
case 1:
state->speed = SPEED_100;
break;
+ case 2:
state->speed = SPEED_1000;
break;
default:
More information about the lede-commits
mailing list