[source] ar71xx/ar93xx_wmac_otp_read_word: fix wrongly used sizeof(*u)

LEDE Commits lede-commits at lists.infradead.org
Sun Jun 11 05:27:49 PDT 2017


lynxis pushed a commit to source.git, branch master:
https://git.lede-project.org/ab116180016dff282e5ad8104b859cc2bca3d5e0

commit ab116180016dff282e5ad8104b859cc2bca3d5e0
Author: Alexander Couzens <lynxis at fe80.eu>
AuthorDate: Sun Jun 11 13:43:55 2017 +0200

    ar71xx/ar93xx_wmac_otp_read_word: fix wrongly used sizeof(*u)
    
    Found-by: Coverity Scan #1330474
    Signed-off-by: Alexander Couzens <lynxis at fe80.eu>
---
 target/linux/ar71xx/patches-4.4/523-MIPS-ath79-OTP-support.patch | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/target/linux/ar71xx/patches-4.4/523-MIPS-ath79-OTP-support.patch b/target/linux/ar71xx/patches-4.4/523-MIPS-ath79-OTP-support.patch
index 6778183..fa5681b 100644
--- a/target/linux/ar71xx/patches-4.4/523-MIPS-ath79-OTP-support.patch
+++ b/target/linux/ar71xx/patches-4.4/523-MIPS-ath79-OTP-support.patch
@@ -111,8 +111,8 @@
 +
 +	BUG_ON(!soc_is_ar933x() && !soc_is_ar934x());
 +	base = ioremap_nocache(AR93XX_WMAC_BASE, AR93XX_WMAC_SIZE);
-+	while (addr > sizeof(hdr)) {
-+		if (!ar93xx_wmac_otp_read(base, addr, hdr, sizeof(hdr)))
++	while (addr > sizeof(hdr_u32)) {
++		if (!ar93xx_wmac_otp_read(base, addr, hdr, sizeof(hdr_u32)))
 +			break;
 +
 +		if (hdr_u32 == 0 || hdr_u32 == ~0)



More information about the lede-commits mailing list