[source] ar71xx/ag71xx_ar7240_get_port_link: fix off-by-one check on argument `port`

LEDE Commits lede-commits at lists.infradead.org
Sun Jun 11 05:27:43 PDT 2017


lynxis pushed a commit to source.git, branch master:
https://git.lede-project.org/d18cb142d5dcdf112095d593b60b8c16c74e986b

commit d18cb142d5dcdf112095d593b60b8c16c74e986b
Author: Alexander Couzens <lynxis at fe80.eu>
AuthorDate: Sun Jun 11 12:43:24 2017 +0200

    ar71xx/ag71xx_ar7240_get_port_link: fix off-by-one check on argument `port`
    
    Found-by: Coverity Scan #1329901
    Signed-off-by: Alexander Couzens <lynxis at fe80.eu>
---
 .../ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_ar7240.c  | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/target/linux/ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_ar7240.c b/target/linux/ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_ar7240.c
index c5aed0d..e457acb 100644
--- a/target/linux/ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_ar7240.c
+++ b/target/linux/ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_ar7240.c
@@ -963,7 +963,7 @@ ar7240_get_port_link(struct switch_dev *dev, int port,
 	struct mii_bus *mii = as->mii_bus;
 	u32 status;
 
-	if (port > AR7240_NUM_PORTS)
+	if (port >= AR7240_NUM_PORTS)
 		return -EINVAL;
 
 	status = ar7240sw_reg_read(mii, AR7240_REG_PORT_STATUS(port));
@@ -1000,7 +1000,7 @@ ar7240_get_port_stats(struct switch_dev *dev, int port,
 {
 	struct ar7240sw *as = sw_to_ar7240(dev);
 
-	if (port > AR7240_NUM_PORTS)
+	if (port >= AR7240_NUM_PORTS)
 		return -EINVAL;
 
 	ar7240sw_capture_stats(as);



More information about the lede-commits mailing list