[source] ip17xx: correct aneg_done return value

LEDE Commits lede-commits at lists.infradead.org
Wed Jun 7 03:25:40 PDT 2017

blogic pushed a commit to source.git, branch master:

commit 2cc61e6e8e951b1480a024fdb66bc539aa163bbc
Author: Sergey Ryazanov <ryazanov.s.a at gmail.com>
AuthorDate: Wed Jun 7 01:25:32 2017 +0300

    ip17xx: correct aneg_done return value
    PHY core treats any positive return value as the auto-negotiation done
    indication. Since we do not actually check any device register in this
    callback then update it to return positive value with a neutral meaning
    instead of the register flag to avoid  confusing for future readers.
    Signed-off-by: Sergey Ryazanov <ryazanov.s.a at gmail.com>
 target/linux/generic/files/drivers/net/phy/ip17xx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/linux/generic/files/drivers/net/phy/ip17xx.c b/target/linux/generic/files/drivers/net/phy/ip17xx.c
index 9eedfd4..85a9617 100644
--- a/target/linux/generic/files/drivers/net/phy/ip17xx.c
+++ b/target/linux/generic/files/drivers/net/phy/ip17xx.c
@@ -1334,7 +1334,7 @@ static int ip17xx_config_aneg(struct phy_device *pdev)
 static int ip17xx_aneg_done(struct phy_device *pdev)
+	return 1;	/* Return any positive value */
 static int ip17xx_update_link(struct phy_device *pdev)

More information about the lede-commits mailing list