[FS#321] BTHomeHub5 Type A dsl_notify.sh fails to set LED

[LEDE Bugs]

The following task has a new comment added:

FS#321 - BTHomeHub5 Type A dsl_notify.sh fails to set LED
User who did this - Mathias Kresin (mkresin)

----------
First of all, it isn't a bug it's intentionally.

And things a complicated with the HH5a. The hub has only three LEDs, but these LEDs are RGB LEDs, where each LED is controlled by three GPIOs. That is why you have red:broadband, green:broadband, blue:broadband.

The GPIO LED driver does not have support for RGB LEDs and you can not use these colours intendant. Means, if you enable red + blue, the LED will be purple. With red + blue + green the LED will be white. If you use some kind of blinking pattern you get nice colour effects. What is missing in the kernel driver is the possibility to define an LED with multiple GPIOs and the value of each GPIO.

I've implemented some kind of [[https://git.lede-project.org/?p=source.git;a=commitdiff;h=551c9c830027b7749895e3ba6b37004570b89e74;hp=32012decc327486bdf6564e6cf55a4acfc744efe|workaround for the power LED]] in failsafe, which disables the green power LED before enabling the red power LED.

I've decided back in the OpenWrt days(!), to show the Internet connection (ppp) status via the broadband LED. The broadband LED will shine blue if a ppp connection is established (link) and will blink blue on rx/tx.

But even having full support for RGB LEDs wouldn't allow to use a single LED for DSL and Internet connection status. It is not possible to use multiple trigger for a single LED.

Assuming we are using broadband:orange (red + green?) for the DSL line status (using red if everything is fine seams to me a bad idea). If the internet connection is terminated but the DSL line is still in sync, you would expect that the broadband LED switches back from blue to orange. But it isn't possible, since the link/rx/tx ppp trigger switches the LED off.

I'm not saying it isn't possible, but to my knowledge it requires a lot of hacks and workarounds to get such a config working. And at least to me it's questionable if the use case is worse adding these workarounds/hacks.

If you still interested in showing the DSL line status via the broadband LED, remove the "config led 'led_internet'" from your /etc/config/system and add the following instead:


config led 'led_dsl'
	option name 'dsl'
	option sysfs 'bthomehubv5a:red:broadband'
	option default '0'

----------

More information can be found at the following URL:
https://bugs.lede-project.org/index.php?do=details&task_id=321#comment998