[PATCH v5][makedumpfile 2/9] Implement kernel kallsyms resolving

[Tao Liu]

Hi Kazu,

Ah, you are right, I missed those. I will fix the fprintf()s in the
macro and send v6.

Thanks,
Tao Liu

On Mon, Jun 15, 2026 at 8:09 PM HAGIO KAZUHITO(萩尾　一仁)
<k-hagio-ab at nec.com> wrote:
>
> Hi Tao,
>
> thank you for the update, almost finished.
> there are a few of slight comments.
>
> On 2026/04/14 19:26, Tao Liu wrote:
>
> > +#define REGISTER_SECTION(T)                                          \
> > +bool register_##T##_section(char *start, char *stop)                 \
> > +{                                                                    \
> > +     struct section_range *new_sr;                                   \
> > +     struct T##_info **p;                                            \
> > +     bool ret = false;                                               \
> > +                                                                     \
> > +     if (!start || !stop) {                                          \
> > +             fprintf(stderr, "%s: Invalid section start/stop\n",     \
> > +                     __func__);                                      \
> > +             goto out;                                               \
> > +     }                                                               \
> > +                                                                     \
> > +     for (p = (struct T##_info **)start;                             \
> > +          p < (struct T##_info **)stop;                              \
> > +          p++) {                                                     \
> > +             if (!add_##T##_modname((*p)->modname))                  \
> > +                     goto out;                                       \
> > +     }                                                               \
> > +                                                                     \
> > +     new_sr = malloc(sizeof(struct section_range));                  \
> > +     if (!new_sr) {                                                  \
> > +             fprintf(stderr, "%s: Not enough memory!\n", __func__);  \
>
> fprintf()s still exist in this macro.
>
> Thanks,
> Kazu