[PATCH v5][makedumpfile 2/9] Implement kernel kallsyms resolving

HAGIO KAZUHITO(萩尾 一仁) k-hagio-ab at nec.com
Mon Jun 15 01:09:27 PDT 2026


Hi Tao,

thank you for the update, almost finished.
there are a few of slight comments.

On 2026/04/14 19:26, Tao Liu wrote:

> +#define REGISTER_SECTION(T)						\
> +bool register_##T##_section(char *start, char *stop)			\
> +{									\
> +	struct section_range *new_sr;					\
> +	struct T##_info **p;						\
> +	bool ret = false;						\
> +									\
> +	if (!start || !stop) {						\
> +		fprintf(stderr, "%s: Invalid section start/stop\n",	\
> +			__func__);					\
> +		goto out;						\
> +	}								\
> +									\
> +	for (p = (struct T##_info **)start;				\
> +	     p < (struct T##_info **)stop;				\
> +	     p++) {							\
> +		if (!add_##T##_modname((*p)->modname))			\
> +			goto out;					\
> +	}								\
> +									\
> +	new_sr = malloc(sizeof(struct section_range));			\
> +	if (!new_sr) {							\
> +		fprintf(stderr, "%s: Not enough memory!\n", __func__);	\

fprintf()s still exist in this macro.

Thanks,
Kazu


More information about the kexec mailing list