[PATCH] Submit physical address to is_phys_addr()

Philipp Rudo prudo at redhat.com
Mon Sep 23 04:47:16 PDT 2024


Hi Alexander,

On Fri, 13 Sep 2024 16:35:00 +0200
Alexander Gordeev <agordeev at linux.ibm.com> wrote:

> ELF program table virtual address is submitted to is_phys_addr()
> function, most likely as a leftover of replaced is_vmalloc_addr()
> function, as result of commit 2e452d75fa78 ("[PATCH v3] Enable
> --mem-usage for s390x."). Submit the physical address instead.

is the patch supposed to fix the bug with /proc/kcore I reported? I
gave it a try on a KVM VM and it's still failing...

Thanks
Philipp

> Signed-off-by: Alexander Gordeev <agordeev at linux.ibm.com>
> ---
>  elf_info.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/elf_info.c b/elf_info.c
> index bc24083..7f3d053 100644
> --- a/elf_info.c
> +++ b/elf_info.c
> @@ -765,7 +765,7 @@ int get_kcore_dump_loads(void)
>  	for (i = 0; i < num_pt_loads; ++i) {
>  		struct pt_load_segment *p = &pt_loads[i];
>  		if (p->phys_start == NOT_PADDR
> -				|| !is_phys_addr(p->virt_start))
> +				|| !is_phys_addr(p->phys_start))
>  			continue;
>  		loads++;
>  	}
> @@ -786,7 +786,7 @@ int get_kcore_dump_loads(void)
>  	for (i = 0, j = 0; i < num_pt_loads; ++i) {
>  		struct pt_load_segment *p = &pt_loads[i];
>  		if (p->phys_start == NOT_PADDR
> -				|| !is_phys_addr(p->virt_start))
> +				|| !is_phys_addr(p->phys_start))
>  			continue;
>  		if (j >= loads) {
>  			free(pls);




More information about the kexec mailing list