[PATCH] Submit physical address to is_phys_addr()

HAGIO KAZUHITO(萩尾 一仁) k-hagio-ab at nec.com
Tue Sep 17 18:09:06 PDT 2024


Hi Alex,

Thanks for the patch.

On 2024/09/13 23:35, Alexander Gordeev wrote:
> ELF program table virtual address is submitted to is_phys_addr()
> function, most likely as a leftover of replaced is_vmalloc_addr()
> function, as result of commit 2e452d75fa78 ("[PATCH v3] Enable
> --mem-usage for s390x."). Submit the physical address instead.

If this leftover causes a failure, could you add the error and brief 
description about it to the commit log?

It looks like currently is_phys_addr() is used only by s390x, and the 
patch looks good to me.

Thanks,
Kazu

> 
> Signed-off-by: Alexander Gordeev <agordeev at linux.ibm.com>
> ---
>   elf_info.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/elf_info.c b/elf_info.c
> index bc24083..7f3d053 100644
> --- a/elf_info.c
> +++ b/elf_info.c
> @@ -765,7 +765,7 @@ int get_kcore_dump_loads(void)
>   	for (i = 0; i < num_pt_loads; ++i) {
>   		struct pt_load_segment *p = &pt_loads[i];
>   		if (p->phys_start == NOT_PADDR
> -				|| !is_phys_addr(p->virt_start))
> +				|| !is_phys_addr(p->phys_start))
>   			continue;
>   		loads++;
>   	}
> @@ -786,7 +786,7 @@ int get_kcore_dump_loads(void)
>   	for (i = 0, j = 0; i < num_pt_loads; ++i) {
>   		struct pt_load_segment *p = &pt_loads[i];
>   		if (p->phys_start == NOT_PADDR
> -				|| !is_phys_addr(p->virt_start))
> +				|| !is_phys_addr(p->phys_start))
>   			continue;
>   		if (j >= loads) {
>   			free(pls);


More information about the kexec mailing list