[PATCH] kexec/fs2dt: Check for NULL pointer in dt_copy_old_root_param()

Madhavan Srinivasan maddy at linux.vnet.ibm.com
Fri Sep 23 00:17:39 PDT 2016


In dt_copy_old_root_param(), FILE * returned
from fopen is not checked for NULL pointer
before passinig to fclose(). This could trigger
a segfault. Patch adds a check.

Signed-off-by: Madhavan Srinivasan <maddy at linux.vnet.ibm.com>
---
 kexec/fs2dt.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/kexec/fs2dt.c b/kexec/fs2dt.c
index 6ed2399759cf..2c1ebdf525f4 100644
--- a/kexec/fs2dt.c
+++ b/kexec/fs2dt.c
@@ -540,7 +540,8 @@ static void dt_copy_old_root_param(void)
 	if (last_cmdline)
 		free(last_cmdline);
 
-	fclose(fp);
+	if (fp)
+		fclose(fp);
 }
 
 /*
-- 
2.7.4




More information about the kexec mailing list