[PATCH] kexec: remove unnecessary return

Simon Horman horms at verge.net.au
Wed Aug 7 04:45:36 EDT 2013


From: Xishi Qiu <qiuxishi at huawei.com>

Code can not run here forever, so remove the unnecessary return.

Signed-off-by: Xishi Qiu <qiuxishi at huawei.com>
Suggested-by: Zhang Yanfei <zhangyanfei at cn.fujitsu.com>
Reviewed-by: Zhang Yanfei <zhangyanfei at cn.fujitsu.com>
Signed-off-by: Simon Horman <horms at verge.net.au>
---
 kernel/kexec.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Andrew, could you consider picking up this patch?

diff --git a/kernel/kexec.c b/kernel/kexec.c
index 59f7b55..2a74f30 100644
--- a/kernel/kexec.c
+++ b/kernel/kexec.c
@@ -1474,11 +1474,8 @@ static int __init __parse_crashkernel(char *cmdline,
 	if (first_colon && (!first_space || first_colon < first_space))
 		return parse_crashkernel_mem(ck_cmdline, system_ram,
 				crash_size, crash_base);
-	else
-		return parse_crashkernel_simple(ck_cmdline, crash_size,
-				crash_base);
 
-	return 0;
+	return parse_crashkernel_simple(ck_cmdline, crash_size, crash_base);
 }
 
 /*
-- 
1.8.3.2




More information about the kexec mailing list