[PATCH] kexec: remove unnecessary return
Zhang Yanfei
zhangyanfei at cn.fujitsu.com
Tue Aug 6 04:19:17 EDT 2013
于 2013/8/6 16:05, Xishi Qiu 写道:
> Code can not run here forever, so remove the unnecessary return.
>
> Signed-off-by: Xishi Qiu <qiuxishi at huawei.com>
> ---
> kernel/kexec.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/kexec.c b/kernel/kexec.c
> index 59f7b55..c14e3ea 100644
> --- a/kernel/kexec.c
> +++ b/kernel/kexec.c
> @@ -1477,8 +1477,6 @@ static int __init __parse_crashkernel(char *cmdline,
> else
> return parse_crashkernel_simple(ck_cmdline, crash_size,
> crash_base);
> -
> - return 0;
> }
>
> /*
>
Hi Xishi,
change
1474 if (first_colon && (!first_space || first_colon < first_space))
1475 return parse_crashkernel_mem(ck_cmdline, system_ram,
1476 crash_size, crash_base);
1477 else
1478 return parse_crashkernel_simple(ck_cmdline, crash_size,
1479 crash_base);
1480
1481 return 0;
to
1474 if (first_colon && (!first_space || first_colon < first_space))
1475 return parse_crashkernel_mem(ck_cmdline, system_ram,
1476 crash_size, crash_base);
1478 return parse_crashkernel_simple(ck_cmdline, crash_size, crash_base);
seems better.
--
Thanks.
Zhang Yanfei
More information about the kexec
mailing list