[PATCH] kexec-tools: don't include every archs Makefile
horms at verge.net.au
Wed May 5 02:44:45 EDT 2010
On Wed, May 05, 2010 at 02:00:58PM +1000, Michael Neuling wrote:
> In message <20100505033123.GB2612 at verge.net.au> you wrote:
> > On Wed, May 05, 2010 at 11:51:10AM +1000, Michael Neuling wrote:
> > > This patches changes the kexec/Makefile to only include the required
> > > arch Makefile.
> > >
> > > Including all arch Makefiles causes unexpected results as changing one
> > > archs Makefile effects all other archs.
> > >
> > > ppc64 recently broke surprisingly because
> > > 6adc05c6e3fdbc8b9f5d915af78ca05d0a09cb17 "some kexec MIPS
> > > improvements" added "CFLAGS +=-Wall -Werror" to
> > > kexec/arch/mips/Makefile. This shouldn't happen.
> > >
> > > Signed-off-by: Michael Neuling <mikey at neuling.org>
> > > ---
> > > Horms: Tested by compiling on x86 and ppc64, but probably needs
> > > testing on other archs before being committed.
> > Unfortunately this breaks make tarball - only kexec/arch/$ARCH is
> > included in the tarball.
> I figured it might break something :-)
> BTW make tarball works here.
> > Perhaps we could introduce $(ARCH)_FLAGS, which I think is
> > consistent with the handling of other variables by the kexec build.
> Seems like a bit of a band aid.
> It still seems pretty broken that we use arch/mips/Makefile for ppc64.
> Looking at 6adc05c6e3fdbc8b9f5d915af78ca05d0a09cb17 and trying to work
> out how it broke ppc64 was pretty annoying.
I agree that its entirely non-obvious and could be improved :-)
More information about the kexec