[PATCH] kexec-tools: don't include every archs Makefile

Michael Neuling mikey at neuling.org
Wed May 5 00:00:58 EDT 2010

In message <20100505033123.GB2612 at verge.net.au> you wrote:
> On Wed, May 05, 2010 at 11:51:10AM +1000, Michael Neuling wrote:
> > This patches changes the kexec/Makefile to only include the required
> > arch Makefile.  
> > 
> > Including all arch Makefiles causes unexpected results as changing one
> > archs Makefile effects all other archs.
> > 
> > ppc64 recently broke surprisingly because
> > 6adc05c6e3fdbc8b9f5d915af78ca05d0a09cb17 "some kexec MIPS
> > improvements" added "CFLAGS +=-Wall -Werror" to
> > kexec/arch/mips/Makefile.  This shouldn't happen.
> > 
> > Signed-off-by: Michael Neuling <mikey at neuling.org>
> > ---
> > Horms: Tested by compiling on x86 and ppc64, but probably needs
> > testing on other archs before being committed.
> Unfortunately this breaks make tarball - only kexec/arch/$ARCH is
> included in the tarball.

I figured it might break something :-)

BTW make tarball works here.

> Perhaps we could introduce $(ARCH)_FLAGS, which I think is
> consistent with the handling of other variables by the kexec build.

Seems like a bit of a band aid.

It still seems pretty broken that we use arch/mips/Makefile for ppc64.

Looking at 6adc05c6e3fdbc8b9f5d915af78ca05d0a09cb17 and trying to work
out how it broke ppc64 was pretty annoying.


More information about the kexec mailing list