[PATCH] x86_64: printf format change
kevint
kevint at lanl.gov
Fri Jan 11 13:10:47 EST 2008
Minor patch to print the reloc_name as a string.
--- kexec-tools-testing-20071030/kexec/arch/x86_64/kexec-elf-rel-
x86_64.c 2007-10-16 21:16:16.000000000 -0600
+++ kexec-tools-testing-20071030-modified/kexec/arch/x86_64/kexec-elf-
rel-x86_64.c 2008-01-10 10:52:22.000000000 -0700
@@ -83,7 +83,7 @@
*(uint32_t *)location = value - address;
break;
default:
- die("Unhandled rela relocation: %lu\n", reloc_name
(r_type));
+ die("Unhandled rela relocation: %s\n", reloc_name
(r_type));
break;
}
return;
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me
and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to
the best
of my knowledge, is covered under an appropriate open
source
license and I have the right under that license to
submit that
work with modifications, whether created in whole or in
part
by me, under the same open source license (unless I am
permitted to submit under a different license), as
indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not
modified
it.
(d) I understand and agree that this project and the
contribution
are public and that a record of the contribution
(including all
personal information I submit with it, including my sign-
off) is
maintained indefinitely and may be redistributed
consistent with
this project or the open source license(s) involved.
Signed-off-by: Kevin Tegtmeier <kevint at lanl.gov>
On Jan 10, 2008, at 8:19 PM, Simon Horman wrote:
> On Thu, Jan 10, 2008 at 11:07:53AM -0700, kevint wrote:
>> I included a one-line patch to kexec-tools-testing, at Bernhard
>> Walle's
>> request. This prints the relocation type as a string. I noticed
>> that
>> other architectures do not use reloc_name, but instead just print the
>> r_type. I find the reloc_name useful.
>
> Hi Kevin,
>
> that looks fine to me. I notice that other archs don't seem to have
> reloc_name(), so unfortunately it looks like a bit of a chore to
> switch
> them over to use it in the log message.
>
> I'm wondering if you could provide a sign-off line as per
> section 5 of http://linux.yyz.us/patch-format.html
>
> --
> Horms
>
********************************************
Kevin Tegtmeier
HPC-3 Scientific Computing Resources
Los Alamos National Laboratory
email: kevint at lanl.gov
phone: 505.667.3488
********************************************
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.infradead.org/pipermail/kexec/attachments/20080111/37193460/attachment.html
More information about the kexec
mailing list