<HTML><BODY style="word-wrap: break-word; -khtml-nbsp-mode: space; -khtml-line-break: after-white-space; "><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">Minor patch to print the reloc_name as a string.</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><BR class="khtml-block-placeholder"></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">--- kexec-tools-testing-20071030/kexec/arch/x86_64/kexec-elf-rel-x86_64.c 2007-10-16 21:16:16.000000000 -0600</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">+++ kexec-tools-testing-20071030-modified/kexec/arch/x86_64/kexec-elf-rel-x86_64.c 2008-01-10 10:52:22.000000000 -0700</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">@@ -83,7 +83,7 @@</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "> *(uint32_t *)location = value - address;</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "> break;</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "> default:</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">- die("Unhandled rela relocation: %lu\n", reloc_name(r_type));</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">+ die("Unhandled rela relocation: %s\n", reloc_name(r_type));</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "> break;</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "> }</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "> return;</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><FONT class="Apple-style-span" color="#303030" face="Courier" size="2"><SPAN class="Apple-style-span" style="font-size: 9.9px;"><BR class="khtml-block-placeholder"></SPAN></FONT></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><FONT class="Apple-style-span" color="#303030" face="Courier" size="2"><SPAN class="Apple-style-span" style="font-size: 9.9px;"><BR class="khtml-block-placeholder"></SPAN></FONT></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><FONT class="Apple-style-span" color="#303030" face="Courier" size="2"><SPAN class="Apple-style-span" style="font-size: 9.9px;">Developer's Certificate of Origin 1.1</SPAN></FONT></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 9.9px/normal Courier; min-height: 11px; "><FONT class="Apple-style-span" color="#303030"><SPAN class="Apple-style-span" style="line-height: 19px;"><BR></SPAN></FONT></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><SPAN class="Apple-style-span" style="line-height: 19px;"><FONT class="Apple-style-span" color="#303030" face="Courier" size="2"><SPAN class="Apple-style-span" style="font-size: 9.9px; line-height: normal;"> </SPAN></FONT><FONT class="Apple-style-span" color="#303030" face="Courier" size="2"><SPAN class="Apple-style-span" style="font-size: 9.9px; line-height: normal;">By making a contribution to this project, I certify that:</SPAN></FONT></SPAN></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 9.9px/normal Courier; min-height: 11px; "><FONT class="Apple-style-span" color="#303030"><SPAN class="Apple-style-span" style="line-height: 19px;"><BR></SPAN></FONT></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><SPAN class="Apple-style-span" style="line-height: 19px;"><FONT class="Apple-style-span" color="#303030" face="Courier" size="2"><SPAN class="Apple-style-span" style="font-size: 9.9px; line-height: normal;"> </SPAN></FONT><FONT class="Apple-style-span" color="#303030" face="Courier" size="2"><SPAN class="Apple-style-span" style="font-size: 9.9px; line-height: normal;">(a) The contribution was created in whole or in part by me and I</SPAN></FONT></SPAN></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><SPAN class="Apple-style-span" style="line-height: 19px;"><FONT class="Apple-style-span" color="#303030" face="Courier" size="2"><SPAN class="Apple-style-span" style="font-size: 9.9px; line-height: normal;"> </SPAN></FONT><FONT class="Apple-style-span" color="#303030" face="Courier" size="2"><SPAN class="Apple-style-span" style="font-size: 9.9px; line-height: normal;">have the right to submit it under the open source license</SPAN></FONT></SPAN></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><SPAN class="Apple-style-span" style="line-height: 19px;"><FONT class="Apple-style-span" color="#303030" face="Courier" size="2"><SPAN class="Apple-style-span" style="font-size: 9.9px; line-height: normal;"> </SPAN></FONT><FONT class="Apple-style-span" color="#303030" face="Courier" size="2"><SPAN class="Apple-style-span" style="font-size: 9.9px; line-height: normal;">indicated in the file; or</SPAN></FONT></SPAN></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 9.9px/normal Courier; min-height: 11px; "><FONT class="Apple-style-span" color="#303030"><SPAN class="Apple-style-span" style="line-height: 19px;"><BR></SPAN></FONT></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><SPAN class="Apple-style-span" style="line-height: 19px;"><FONT class="Apple-style-span" color="#303030" face="Courier" size="2"><SPAN class="Apple-style-span" style="font-size: 9.9px; line-height: normal;"> </SPAN></FONT><FONT class="Apple-style-span" color="#303030" face="Courier" size="2"><SPAN class="Apple-style-span" style="font-size: 9.9px; line-height: normal;">(b) The contribution is based upon previous work that, to the best</SPAN></FONT></SPAN></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><SPAN class="Apple-style-span" style="line-height: 19px;"><FONT class="Apple-style-span" color="#303030" face="Courier" size="2"><SPAN class="Apple-style-span" style="font-size: 9.9px; line-height: normal;"> </SPAN></FONT><FONT class="Apple-style-span" color="#303030" face="Courier" size="2"><SPAN class="Apple-style-span" style="font-size: 9.9px; line-height: normal;">of my knowledge, is covered under an appropriate open source</SPAN></FONT></SPAN></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><SPAN class="Apple-style-span" style="line-height: 19px;"><FONT class="Apple-style-span" color="#303030" face="Courier" size="2"><SPAN class="Apple-style-span" style="font-size: 9.9px; line-height: normal;"> </SPAN></FONT><FONT class="Apple-style-span" color="#303030" face="Courier" size="2"><SPAN class="Apple-style-span" style="font-size: 9.9px; line-height: normal;">license and I have the right under that license to submit that</SPAN></FONT></SPAN></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><SPAN class="Apple-style-span" style="line-height: 19px;"><FONT class="Apple-style-span" color="#303030" face="Courier" size="2"><SPAN class="Apple-style-span" style="font-size: 9.9px; line-height: normal;"> </SPAN></FONT><FONT class="Apple-style-span" color="#303030" face="Courier" size="2"><SPAN class="Apple-style-span" style="font-size: 9.9px; line-height: normal;">work with modifications, whether created in whole or in part</SPAN></FONT></SPAN></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><SPAN class="Apple-style-span" style="line-height: 19px;"><FONT class="Apple-style-span" color="#303030" face="Courier" size="2"><SPAN class="Apple-style-span" style="font-size: 9.9px; line-height: normal;"> </SPAN></FONT><FONT class="Apple-style-span" color="#303030" face="Courier" size="2"><SPAN class="Apple-style-span" style="font-size: 9.9px; line-height: normal;">by me, under the same open source license (unless I am</SPAN></FONT></SPAN></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><SPAN class="Apple-style-span" style="line-height: 19px;"><FONT class="Apple-style-span" color="#303030" face="Courier" size="2"><SPAN class="Apple-style-span" style="font-size: 9.9px; line-height: normal;"> </SPAN></FONT><FONT class="Apple-style-span" color="#303030" face="Courier" size="2"><SPAN class="Apple-style-span" style="font-size: 9.9px; line-height: normal;">permitted to submit under a different license), as indicated</SPAN></FONT></SPAN></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><SPAN class="Apple-style-span" style="line-height: 19px;"><FONT class="Apple-style-span" color="#303030" face="Courier" size="2"><SPAN class="Apple-style-span" style="font-size: 9.9px; line-height: normal;"> </SPAN></FONT><FONT class="Apple-style-span" color="#303030" face="Courier" size="2"><SPAN class="Apple-style-span" style="font-size: 9.9px; line-height: normal;">in the file; or</SPAN></FONT></SPAN></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 9.9px/normal Courier; min-height: 11px; "><FONT class="Apple-style-span" color="#303030"><SPAN class="Apple-style-span" style="line-height: 19px;"><BR></SPAN></FONT></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><SPAN class="Apple-style-span" style="line-height: 19px;"><FONT class="Apple-style-span" color="#303030" face="Courier" size="2"><SPAN class="Apple-style-span" style="font-size: 9.9px; line-height: normal;"> </SPAN></FONT><FONT class="Apple-style-span" color="#303030" face="Courier" size="2"><SPAN class="Apple-style-span" style="font-size: 9.9px; line-height: normal;">(c) The contribution was provided directly to me by some other</SPAN></FONT></SPAN></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><SPAN class="Apple-style-span" style="line-height: 19px;"><FONT class="Apple-style-span" color="#303030" face="Courier" size="2"><SPAN class="Apple-style-span" style="font-size: 9.9px; line-height: normal;"> </SPAN></FONT><FONT class="Apple-style-span" color="#303030" face="Courier" size="2"><SPAN class="Apple-style-span" style="font-size: 9.9px; line-height: normal;">person who certified (a), (b) or (c) and I have not modified</SPAN></FONT></SPAN></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><SPAN class="Apple-style-span" style="line-height: 19px;"><FONT class="Apple-style-span" color="#303030" face="Courier" size="2"><SPAN class="Apple-style-span" style="font-size: 9.9px; line-height: normal;"> </SPAN></FONT><FONT class="Apple-style-span" color="#303030" face="Courier" size="2"><SPAN class="Apple-style-span" style="font-size: 9.9px; line-height: normal;">it.</SPAN></FONT></SPAN></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 9.9px/normal Courier; min-height: 11px; "><FONT class="Apple-style-span" color="#303030"><SPAN class="Apple-style-span" style="line-height: 19px;"><BR></SPAN></FONT></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><SPAN class="Apple-style-span" style="line-height: 19px;"><FONT class="Apple-style-span" color="#303030" face="Courier" size="2"><SPAN class="Apple-style-span" style="font-size: 9.9px; line-height: normal;"> </SPAN></FONT><FONT class="Apple-style-span" color="#303030" face="Courier" size="2"><SPAN class="Apple-style-span" style="font-size: 9.9px; line-height: normal;">(d) I understand and agree that this project and the contribution</SPAN></FONT></SPAN></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><SPAN class="Apple-style-span" style="line-height: 19px;"><FONT class="Apple-style-span" color="#303030" face="Courier" size="2"><SPAN class="Apple-style-span" style="font-size: 9.9px; line-height: normal;"> </SPAN></FONT><FONT class="Apple-style-span" color="#303030" face="Courier" size="2"><SPAN class="Apple-style-span" style="font-size: 9.9px; line-height: normal;">are public and that a record of the contribution (including all</SPAN></FONT></SPAN></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><SPAN class="Apple-style-span" style="line-height: 19px;"><FONT class="Apple-style-span" color="#303030" face="Courier" size="2"><SPAN class="Apple-style-span" style="font-size: 9.9px; line-height: normal;"> </SPAN></FONT><FONT class="Apple-style-span" color="#303030" face="Courier" size="2"><SPAN class="Apple-style-span" style="font-size: 9.9px; line-height: normal;">personal information I submit with it, including my sign-off) is</SPAN></FONT></SPAN></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><SPAN class="Apple-style-span" style="line-height: 19px;"><FONT class="Apple-style-span" color="#303030" face="Courier" size="2"><SPAN class="Apple-style-span" style="font-size: 9.9px; line-height: normal;"> </SPAN></FONT><FONT class="Apple-style-span" color="#303030" face="Courier" size="2"><SPAN class="Apple-style-span" style="font-size: 9.9px; line-height: normal;">maintained indefinitely and may be redistributed consistent with</SPAN></FONT></SPAN></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><SPAN class="Apple-style-span" style="line-height: 19px;"><FONT class="Apple-style-span" color="#303030" face="Courier" size="2"><SPAN class="Apple-style-span" style="font-size: 9.9px; line-height: normal;"> </SPAN></FONT><FONT class="Apple-style-span" color="#303030" face="Courier" size="2"><SPAN class="Apple-style-span" style="font-size: 9.9px; line-height: normal;">this project or the open source license(s) involved.</SPAN></FONT></SPAN></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; line-height: 19px; "><FONT class="Apple-style-span" color="#303030" face="Courier" size="2"><SPAN class="Apple-style-span" style="font-size: 9.9px;"><BR class="khtml-block-placeholder"></SPAN></FONT></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><SPAN class="Apple-style-span" style="line-height: 19px;"><FONT class="Apple-style-span" color="#303030" face="Courier" size="2"><SPAN class="Apple-style-span" style="font-size: 9.9px; line-height: normal;"> </SPAN></FONT><FONT class="Apple-style-span" color="#303030" face="Courier" size="2"><SPAN class="Apple-style-span" style="font-size: 9.9px; line-height: normal;">Signed-off-by: Kevin Tegtmeier <<A href="mailto:kevint@lanl.gov">kevint@lanl.gov</A>></SPAN></FONT></SPAN></DIV><SPAN class="Apple-style-span" style="line-height: 19px;"><BR></SPAN><DIV><DIV>On Jan 10, 2008, at 8:19 PM, Simon Horman wrote:</DIV><BR class="Apple-interchange-newline"><BLOCKQUOTE type="cite"><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">On Thu, Jan 10, 2008 at 11:07:53AM -0700, kevint wrote:</DIV> <BLOCKQUOTE type="cite"><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">I included a one-line patch to kexec-tools-testing, at Bernhard Walle's<SPAN class="Apple-converted-space"> </SPAN></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">request.<SPAN class="Apple-converted-space"> </SPAN>This prints the relocation type as a string.<SPAN class="Apple-converted-space"> </SPAN>I noticed that<SPAN class="Apple-converted-space"> </SPAN></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">other architectures do not use reloc_name, but instead just print the<SPAN class="Apple-converted-space"> </SPAN></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">r_type.<SPAN class="Apple-converted-space"> </SPAN>I find the reloc_name useful.</DIV> </BLOCKQUOTE><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; min-height: 14px; "><BR></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">Hi Kevin,</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; min-height: 14px; "><BR></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">that looks fine to me. I notice that other archs don't seem to have</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">reloc_name(), so unfortunately it looks like a bit of a chore to switch</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">them over to use it in the log message.</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; min-height: 14px; "><BR></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">I'm wondering if you could provide a sign-off line as per</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">section 5 of <A href="http://linux.yyz.us/patch-format.html">http://linux.yyz.us/patch-format.html</A></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; min-height: 14px; "><BR></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">--<SPAN class="Apple-converted-space"> </SPAN></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">Horms</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; min-height: 14px; "><BR></DIV> </BLOCKQUOTE></DIV><BR><DIV> <SPAN class="Apple-style-span" style="border-collapse: separate; border-spacing: 0px 0px; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; text-align: auto; -khtml-text-decorations-in-effect: none; text-indent: 0px; -apple-text-size-adjust: auto; text-transform: none; orphans: 2; white-space: normal; widows: 2; word-spacing: 0px; "><DIV>********************************************</DIV><DIV>Kevin Tegtmeier</DIV><DIV>HPC-3 Scientific Computing Resources</DIV><DIV>Los Alamos National Laboratory</DIV><DIV>email: <A href="mailto:kevint@lanl.gov">kevint@lanl.gov</A></DIV><DIV>phone: 505.667.3488</DIV><DIV>********************************************</DIV><DIV><BR class="khtml-block-placeholder"></DIV><BR class="Apple-interchange-newline"></SPAN> </DIV><BR></BODY></HTML>