[PATCH] kexec ppc64: fix misaligned cmdline
david at gibson.dropbear.id.au
Mon Jun 4 20:16:32 EDT 2007
On Tue, Jun 05, 2007 at 09:56:37AM +1000, Miichael Neuling wrote:
> > > If the cmdline changes between boots, we can get misalignment of the
> > > bootargs entry, which in turn corrupts our device tree blob and hence
> > > kills our kexec boot.
> > >
> > > Specifically, if the cmdline length was >= 8 before and the new cmdline
> > > length is < 8, we can get corruption.
> > Hrm. Have you considered using dtc for this conversion, rather than
> > this somewhat dubious looking fs2dt?
> Numerous times.
> fs2dt needs to be converted to use the device tree library, but that
> will take a lot more work than a 5 minute patch.
Well, sure.. but do you need fs2dt at all. dtc has an "fs" input
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
More information about the kexec