[PATCH] kexec ppc64: fix misaligned cmdline

David Gibson david at gibson.dropbear.id.au
Mon Jun 4 19:49:17 EDT 2007


On Mon, Jun 04, 2007 at 05:23:45PM +1000, Miichael Neuling wrote:
> If the cmdline changes between boots, we can get misalignment of the
> bootargs entry, which in turn corrupts our device tree blob and hence
> kills our kexec boot.  
> 
> Specifically, if the cmdline length was >= 8 before and the new cmdline
> length is < 8, we can get corruption.

Hrm.  Have you considered using dtc for this conversion, rather than
this somewhat dubious looking fs2dt?

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson



More information about the kexec mailing list