[PATCH] P2P: Do not use AP PSK 4-way offload for GO

Jouni Malinen j at w1.fi
Sat Jun 13 06:45:27 PDT 2026


On Fri, Jun 12, 2026 at 07:57:44PM +0800, Chung-Hsien Hsu wrote:
> WPA_DRIVER_FLAGS2_4WAY_HANDSHAKE_AP_PSK describes support for
> WPA-Personal 4-way handshake offload in AP mode. A P2P GO is started
> through the AP/hostapd code path in wpa_supplicant, but using that
> capability for P2P GO requires separate driver/firmware support.

That sounds like a constraint for a very specific device whereas this
implementation is supposed to work with all devices, i.e., included
cases where no such constraint exists and where this change might
actually break something.

> The AP code currently uses this flag in two places: to pass a PSK/PMK
> to the driver when setting the beacon and to skip starting the hostapd
> WPA authenticator for a newly associated STA. On drivers that advertise
> the AP capability but cannot use it for P2P GO, this can leave the P2P
> client without a working 4-way handshake and break group formation.
> 
> Add an internal BSS configuration flag to disable AP PSK 4-way handshake
> offload for P2P GO and P2P group formation. Keep the original driver
> capability unchanged so normal AP mode continues to use the offload.

This does not feel like the correct way of addressing this issue.
Instead, a new driver capability bit might be needed to indicate
different capabilities for (non-P2P) AP vs. P2P GO as far as this
offload mechanism is concerned.

-- 
Jouni Malinen                                            PGP id EFC895FA



More information about the Hostap mailing list