[PATCH] gas_query: use announced comeback_delay for Comeback Response

[Jouni Malinen]

On Tue, May 05, 2026 at 08:05:30PM +0200, Gustavo Bertoli wrote:
> Currently, the GAS client manages the Comeback Response wait timer
> (gas_query_rx_comeback_timeout) using value based on GAS_QUERY_WAIT_TIME_COMEBACK.
> This timer fails to take the server-announced comeback_delay into
> consideration.

The wait for the GAS comeback happens before sending the GAS comeback
request (see gas_query_tx_comeback_req_delay), not after having sent
that frame.

> During DPP Enterprise provisioning, a DPP Configurator may announce
> longer comeback_delay (dpp_supplicant.c, comeback_delay = 1000).
> Because the client only waits 160 ms for the response,
> it prematurely times out and restarts the GAS dialog with a new
> dialog token.

The client waits 1000 ms before sending the comeback request..

> This change fix protocol-level asymmetry by making the client respect the
> server's provided delay. The Comeback Response wait timer is now derived
> from the server's announced comeback_delay (plus a 10 ms margin for
> processing delay).

Are you saying you don't see that wait before the comeback request is
sent? If so, that needs to be fixed. It is not correct to wait a longer
dynamic amount of time after having sent the comeback request.

-- 
Jouni Malinen                                            PGP id EFC895FA