[PATCH] tests: autogo: Use group control interface for GO commands

Jouni Malinen j at w1.fi
Thu Jan 5 06:06:06 PST 2017


On Mon, Jan 02, 2017 at 10:53:05AM +0000, Otcheretianski, Andrei wrote:
> p2p_device isn't the issue here.  The test is failing when p2p_no_group_iface is 0.

Failing? Or being skipped? It does not fail for me even if I set
p2p_go_group_iface=0 on dev[0] (the GO). Sure, it does not run the
actual test, but that's different from failing..

> Currently the default in reset() is p2p_no_group_iface = 1, but we reuse some of hwsim tests with real hw internally and use a different config.

This is not supported or even supposed to work as far as
p2p_no_group_iface parameter is concerned. Number of test cases set this
to 0 when such behavior is tested while some other test cases depend on
the default value being used and will fail if something forces incorrect
p2p_no_group_iface value..

The proper way to run such testing would be to add more test cases to
get the needed coverage for both the p2p_no_group_iface=0 and
p2p_no_group_iface=1 cases without having to do something external to
starts tests with different configuration.

-- 
Jouni Malinen                                            PGP id EFC895FA



More information about the Hostap mailing list