[PATCH] tests: autogo: Use group control interface for GO commands

Otcheretianski, Andrei andrei.otcheretianski at intel.com
Mon Jan 2 02:53:05 PST 2017


> -----Original Message-----
> From: Jouni Malinen [mailto:j at w1.fi]
> Sent: Friday, December 30, 2016 23:55
> To: Otcheretianski, Andrei <andrei.otcheretianski at intel.com>
> Cc: hostap at lists.infradead.org; Stern, Avraham <avraham.stern at intel.com>
> Subject: Re: [PATCH] tests: autogo: Use group control interface for GO
> commands
> 
> On Thu, Dec 29, 2016 at 11:37:58AM +0200, Andrei Otcheretianski wrote:
> > The channel switch command is intended for the GO interface, but it is
> > not sent on the group control interface. For configurations that use a
> > separate interface for P2P groups, this will fail the test.
> >
> > Fix this by sending the channel switch command on the group control
> > interface and waiting for the channel switch event on the global
> > control interface.
> 
> While this sounds like a reasonable change, I'd like to understand how to
> reproduce this.. I don't see autogo_chan_switch failing with
> mac80211_hwsim.support_p2p_device=1 nor could I get a test case with
> HWSIMRadio(use_p2p_device=True)... to fail in this manner either.

p2p_device isn't the issue here.  The test is failing when p2p_no_group_iface is 0.
Currently the default in reset() is p2p_no_group_iface = 1, but we reuse some of hwsim tests with real hw internally and use a different config.

Andrei

> 
> --
> Jouni Malinen                                            PGP id EFC895FA



More information about the Hostap mailing list