[PATCH] remove duplicate dl_list_init for global_ctrl_dst

Michael Braun michael-dev at fami-braun.de
Fri Oct 21 04:11:56 PDT 2016


Commit 56885eecf402 ("hostapd: Add UDP support for ctrl_iface") added
dl_list_init for global_ctrl_dst to hostapd_global_ctrl_iface_init.

Though, hostapd_global_ctrl_iface_init is only called from main.c:main,
which already initializes global_ctrl_dst unconditionally before.
Save with global_ctrl_sock.

Remove this duplicate initialization.

Signed-off-by: Michael Braun <michael-dev at fami-braun.de>
---
 hostapd/ctrl_iface.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/hostapd/ctrl_iface.c b/hostapd/ctrl_iface.c
index d563831..dadc4b7 100644
--- a/hostapd/ctrl_iface.c
+++ b/hostapd/ctrl_iface.c
@@ -3506,8 +3506,6 @@ int hostapd_global_ctrl_iface_init(struct hapd_interfaces *interface)
 		}
 	}
 
-	dl_list_init(&interface->global_ctrl_dst);
-	interface->global_ctrl_sock = -1;
 	os_get_random(gcookie, COOKIE_LEN);
 
 #ifdef CONFIG_CTRL_IFACE_UDP_REMOTE
-- 
2.1.4




More information about the Hostap mailing list