WPS connection request replies time-out when it actually gets a driver error

[Jose Blanquicet]

Hi,

We are testing WPS by using wpa_supplicant v2.5 on Linux laptop and
CSR6030 chip. The interface indicates that it supports WPS but when we
try to connect using wps_pbc this is what we got:

> wps_pbc
OK
<3>CTRL-EVENT-SCAN-RESULTS
<3>WPS-AP-AVAILABLE
<3>CTRL-EVENT-SCAN-RESULTS
<3>WPS-AP-AVAILABLE-PBC
<3>Trying to associate with 14:cc:20:b7:53:27 (SSID='Digicom_TpLink'
freq=2462 MHz)
<3>Association request to the driver failed
<3>Authentication with 14:cc:20:b7:53:27 timed out.
<3>CTRL-EVENT-DISCONNECTED bssid=14:cc:20:b7:53:27 reason=3 locally_generated=1
<3>CTRL-EVENT-SCAN-RESULTS
<3>WPS-AP-AVAILABLE-PBC
<3>Trying to associate with 14:cc:20:b7:53:27 (SSID='Digicom_TpLink'
freq=2462 MHz)
<3>Association request to the driver failed
<3>Authentication with 14:cc:20:b7:53:27 timed out.
<3>CTRL-EVENT-DISCONNECTED bssid=14:cc:20:b7:53:27 reason=3 locally_generated=1
<3>CTRL-EVENT-SCAN-RESULTS

... It repeats during the walk time (2 minutus) timeout ...

<3>WPS-TIMEOUT Requested operation timed out
<3>CTRL-EVENT-DISCONNECTED bssid=14:cc:20:b7:53:27 reason=3 locally_generated=1

The callback from WPS.Start method does not indicate any error thus
the upper layers will only receive a signal indicating WPS-TIMEOUT
after the 2 min when actually it was an error with the driver. Could
you confirm us that this is the desired behavior?

We suggest to follow the same behavior of the WPA2 connections, where
it only performs X attempts and then it stops and indicates a signal
reporting CONN_FAILED further than only indicated
CTR-EVENT-DISCONNECTED. In the case of WPS, then wpa_supplicant should
emit a signal (e.g. WPS.Event) indicating that the WPS Session fails.
Doing so, programs at upper layer will be able to distinguish between
a real WPS timeout and when there was an error like the one we got
with our driver. In this way those programs will have enough
information to avoid to retry on the same interface and try on another
which could successfully get connected.

What do you think?

Jose Blanquicet