[PATCH 14/18] wpa_supplicant: remove disconnected APs from BSS table

[Jouni Malinen]

On Tue, Sep 27, 2016 at 07:25:58AM +0000, Otcheretianski, Andrei wrote:
> > From: Jouni Malinen [mailto:j at w1.fi]
> > What is that "probably out of range" expectation based on?
> 
> Because the event is locally generated and the reason is DISASSOC_DUE_TO_INACTIVITY

I had to look at mac80211 to find this behavior.. I think it would be
nicer if there were a more explicit driver notification of the
disconnection happening due to the AP becoming unreachable since another
driver could use this specific reason code to indicate something
completely different. Anyway, this can do for now.

> > This gets called when the AP is sending out a Deauthentication/Disassociation
> > frame. If we receive that frame, obviously the AP is not out of range.. I don't
> > see why we would remove a BSS entry for an AP from which we are able to
> > receive a frame.
> 
> It is also called for locally generated DEAUTH, otherwise curr==NULL.

Somehow I missed this being in the same function.. Based on that review
of mac80211 behavior, I applied this with additional notes pointing out
why this indicates the AP being likely out of range with mac80211-based
drivers.

-- 
Jouni Malinen                                            PGP id EFC895FA