[PATCH] mka: Some bug fixes

Jouni Malinen j at w1.fi
Sun Dec 11 10:33:47 PST 2016

On Mon, Dec 05, 2016 at 08:56:23PM +0530, Badrish Adiga H R wrote:
> 1. API ieee802_1x_mka_decode_dist_sak_body wrongly puts
> participant->to_use_sak to TRUE, if invalid DIstributed SAK Parameter
> Set is received
> 2. when number of live peers become 0, the flags such lrx, ltx, orx,
> otx etc. needs to be cleared. In MACsec PSK mode, these stale values
> create problems, while re-establishing CA...

These sound completely independent changes and as such, should be split
into two separate patches. As far as (1) is concerned, I'm not sure I
followed the previous thread regarding the change. So this does not
actually fix any observable behavior? It would be good for the commit
message to be clear on why this change is needed and what impact it has
on behavior.

For (2), could you please be more specific on "create problems"? I.e.,
describe what those problems are and how one would notice that in
practice (i.e., what kind of incorrect behavior this fixes)?

Jouni Malinen                                            PGP id EFC895FA

More information about the Hostap mailing list