p2p_persistent_group bit in p2p.conf is missing

Jouni Malinen j at w1.fi
Thu Dec 1 13:11:56 PST 2016


On Tue, Nov 29, 2016 at 04:32:26PM +0530, Avichal Agarwal wrote:
> "http://w1.fi/cgit/hostap/commit/wpa_supplicant/wpa_supplicant_i.h?id=5aeebc48e8449e39a8ad0f2f1c525464ad94e837"
> 
> static inline int network_is_persistent_group(struct wpa_ssid *ssid)
> {
> -	return ((ssid->disabled == 2) || ssid->p2p_persistent_group);
> +	return ssid->disabled == 2 && ssid->p2p_persistent_group;
> }
> 
> Regarding above patch p2p_persistent_group bit is not saved in p2p.conf file.
> So when p2p.conf file is read by supplicant it register persistent network entry
> in '/fi/w1/wpa_supplicant1/Interfaces/1/Networks while it should be registered in
> '/fi/w1/wpa_supplicant1/Interfaces/1/PersistentGroups. So should I provide a
> patch for it , Or I am missing something.

Yes, please do provide a patch to fix this. The identified commit fixes
an issue and I don't want that fix to be lost, but if this causes issues
for the case where reading persistent group information stored in the
configuration file, that side should clearly be fixed.

-- 
Jouni Malinen                                            PGP id EFC895FA



More information about the Hostap mailing list