[RFC 3/6] mesh: Allow DFS channels to be selected if dfs is enabled

Jouni Malinen j at w1.fi
Thu Dec 1 10:55:44 PST 2016

On Mon, Nov 28, 2016 at 04:38:40PM +0100, Benjamin Berg wrote:
> Note: DFS is assumed to be usable if a country code has been set

> diff --git a/wpa_supplicant/wpa_supplicant.c b/wpa_supplicant/wpa_supplicant.c
> @@ -1862,6 +1862,9 @@ void ibss_mesh_setup_freq(struct wpa_supplicant *wpa_s,
>  	struct hostapd_freq_params vht_freq;
>  	int chwidth, seg0, seg1;
>  	u32 vht_caps = 0;
> +	/* Assume DFS is allowed if country is set for now! */
> +	int dfs_enabled = wpa_s->conf->country[0] &&
> +			  (wpa_s->drv_flags & WPA_DRIVER_FLAGS_RADAR);

This function is used both for IBSS and mesh. Did you have something
here or in the other patches to prevent IBSS from getting the DFS
capability? These should be kept separate for IBSS and mesh since the
rules are likely somewhat different on who controls operations and also
on how to expected non-DFS-capable devices to behave. In other words,
let's not enable DFS for IBSS as part of this set unless someone has
really tested and thought about that case as well.

Jouni Malinen                                            PGP id EFC895FA

More information about the Hostap mailing list