[PATCH] Interworking: Re-trigger scan if no connect attempt is done

[Mikael Kanstrup]

2014-05-31 17:46 GMT+02:00 Jouni Malinen <j at w1.fi>:
> On Wed, May 28, 2014 at 01:26:34PM +0200, Mikael Kanstrup wrote:
>> For one specific case when running with interworking enabled
>> the re-initialisation of the background scan timer is missing.
>> This makes auto connect to a configured network fail.
>
> Thanks, applied.
>
>> The case is:
>> - Interworking credentials available
>> - Auto interworking is enabled
>> - Interwokring auto select is disabled
>> - No configured (enabled and non blacklisted) networks are present
>>   in scan results list.
>> - Interworking finds matching networks
>
> Though, this looks somewhat inaccurate or at least the test case I was
> able to generate has the "No configured networks" replaced with "No
> fully matching networks", i.e., for Interworking find to find a match,
> there needs to be an enabled network. Anyway, the fix itself remains
> as-is.

I was not clear enough on the scenario. This is the whole scenario:

- Interworking credentials available
- Auto interworking is enabled
- Interworking auto select is disabled

Then configure a network and associate to it. Go out of AP range (or
turn AP off). AP is kept cached in scan results until aging algorithm
removes them later on. Supplicant tries to associate a number of times
before the network is marked as temporarily disabled. After this
interworking kicks in and finds the just disabled network as a
candidate to connect to (through function
interworking_find_network_match) but decides not to connect to it
(auto select disabled). Now no scan timer is setup. The patch solves
this case.

Regards
Mikael Kanstrup