[Projekt-wlan] [PATCH v4 24/25] VLAN: do not remove VLAN interfaces due to kernel bug

[Sergey Ryazanov]

Hi,

2013/8/1 michael-dev <michael-dev at fami-braun.de>:
> Hi,
>
> Am 31.07.2013 20:53, schrieb Sergey Ryazanov:
>
>> May be I missing something, but why you are try to avoid triggering of
>> the kernel bug by placing workaround inside hostapd? May be we should
>> fix kernel bug itself?
>
> of course the kernel (or whatever actually is the cause) should be fixed as
> well.
>
If so, could you create a bug report and send it to the linux-wireless list?

> Although the main reason for this change was the kernel issue, I think that
> limiting the churn for creating and removing interfaces could also help to
> mitigate some special kinds of DOS attacks, where the kernel would become
> busy removing and creating interfaces all the time. So this change is useful
> even without any kernel bug.
>
In such case you need a more generic mechanism, which limit client
connection rate. Or you prefer to add such workaround for each
time-consuming operation?

> Additionally, with this change I can actually use this changeset in
> production without the aps regularly crashing, so it really helps.
>
Yes, may be this patch improves situation, but why you are try to push
them into the main hostapd code, where it could stay forever, instead
of keep them locally, until kernel fix would be ready.

-- 
BR,
Sergey