[PATCH 1/2] fix compiler warning (return type declared as u64 but was void*)

Jouni Malinen j
Sat Oct 29 09:14:24 PDT 2011

On Fri, Aug 19, 2011 at 11:47:57AM +0200, Mikael Wikstr?m wrote:
> diff --git a/src/drivers/driver.h b/src/drivers/driver.h
> @@ -2190,7 +2190,7 @@ struct wpa_driver_ops {
> -	u64 (*p2p_sd_request)(void *priv, const u8 *dst,
> +	void* (*p2p_sd_request)(void *priv, const u8 *dst,
>  			      const struct wpabuf *tlvs);

I agree that this needs to be fixed to get rid of compiler warnings, but
this way of fixing this does not look correct. The problem here is that
a 64-bit kernel could return a 64-bit cookie value and in the case of
32-bit user space, void* would not be large enough to handle that.

Jouni Malinen                                            PGP id EFC895FA

More information about the Hostap mailing list