[PATCH] For MS-CHAP, convert the password from UTF-8 to UCS-2.

Evan Broder evan
Fri Oct 28 14:30:11 PDT 2011


On Fri, Oct 28, 2011 at 2:26 PM, Jouni Malinen <j at w1.fi> wrote:
> On Wed, Oct 26, 2011 at 06:46:32PM -0700, Evan Broder wrote:
>> Hmm, ok. I wasn't aware of the WPA_PUT_* macros, so I've re-written
>> the code to use those instead. New patch is attached.
>
> Thanks! Applied with couple of fixes. Though, it would be a good idea to
> test patches before submitting them. This one did not compile due to a
> typo in a variable name and even with that fixed, authentication did not
> work because the returned UCS-2 string value was doubled (bytes vs.
> characters)..

Ah, crud. Sorry about that! I had both of those fixes sitting in my
working copy and must have just forgotten to append to the commit.

Thanks for your feedback and for taking the patch, though

- Evan



More information about the Hostap mailing list