[PATCH 00/14] TDLS support for nl80211 drivers

[Arik Nemtsov]

On Sun, Oct 23, 2011 at 21:28, Jouni Malinen <j at w1.fi> wrote:
> On Mon, Sep 26, 2011 at 01:55:21PM +0300, Arik Nemtsov wrote:
> Thanks! Applied. Please note that I changes some of driver_ops design
> and did various cleanup changes, so it could be a good idea to re-test
> this in your setup.

Will do.

>> Tested with wl12xx hardware, with a nl80211/mac80211 based driver.
>
> Hmm.. How exactly did you get this working? My tests with mac80211_hwsim
> (after making it claim TDLS support) resulted in various kernel panics
> (minstral does not exactly like the STA entry with no supported rates)
> and cfg80211 rejecting the key configuration for the direct link. The
> latter one is now fixed in wpa_supplicant (driver_nl80211.c).

Well I didn't test with mac80211_hwsim. I tested with a modified
experimental wl12xx firmware (and driver).
Since wl12xx has FW based rate control, these parts have unfortunately
been neglected.

I should also mention that the experimental FW doesn't support peer
keys yet, so the encrypted connection flow is not well tested with
wl12xx.
Kalyan (successfully) tested encryption with an earlier version of the
patches and a nl80211 based out-of-tree driver, but I guess the
current version might have been broken. Thanks for fixing this. We'll
be able to test this "for real" in the near future.

>
> I do have this working with mac80211_hwsim now, i.e., I do see frames
> first going with FromDS/ToDS flags and then after TDLS setup without
> those and finally after teardown, back to FromDS/ToDS flags and AP path.
> However, this requires some kernel fixes (to be discussed on
> linux-wireless).

Thanks for adding the support. I'll take a look at the patches.

Arik