[PATCH v5 4/4] hostapd: add Automatic Channel Selection (ACS) support

Luis R. Rodriguez lrodriguez
Thu Jul 28 10:12:43 PDT 2011


On Thu, Jul 28, 2011 at 10:07 AM, Pavel Roskin <proski at gnu.org> wrote:
> On 07/26/2011 07:19 PM, Luis R. Rodriguez wrote:
>> @@ -1736,7 +1736,18 @@ struct hostapd_config * hostapd_config_read(const char *fname)
>> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? errors++;
>> ? ? ? ? ? ? ? ? ? ? ? }
>> ? ? ? ? ? ? ? } else if (os_strcmp(buf, "channel") == 0) {
>> - ? ? ? ? ? ? ? ? ? ? conf->channel = atoi(pos);
>> + ? ? ? ? ? ? ? ? ? ? if (os_strcmp(pos, "acs_survey") == 0) {
>> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? conf->channel = 0;
>> + ? ? ? ? ? ? ? ? ? ? } else
>> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? conf->channel = atoi(pos);
>
> It would be nice to enable ACS also if "channel" is not set at all. ?It
> may look strange from the point of view of the code authors. ?However,
> it makes sense from the point of view of the end user. ?If something is
> not specified, the driver should be able to make a reasonable choice by
> itself.

Sure, patch welcomed.

 Luis



More information about the Hostap mailing list