[PATCH] nl80211 driver: fix beacon interval setting

[Johannes Berg]

On Tue, 2008-06-03 at 17:38 +0300, Jouni Malinen wrote:
> On Wed, May 21, 2008 at 11:35:30PM +0200, Johannes Berg wrote:
> 
> > Ok, I looked at this, but I really need the ifname in more functions:
> > 
> >  - del_beacon (could be hacked around by looking at the bssid.. yuck)
> 
> del_beacon() is an internal driver_nl80211.c function and it is only
> called from i802_deinit().. If this is needed separately for each
> virtual interface, it would be up to driver_nl80211.c to iterate through
> the interfaces..

Oh, ok, sure.

> >  - set_beacon_int
> 
> Are you really planning on supporting different beacon intervals for
> virtual interfaces?

Not entirely sure, but I think Ralink hardware actually supports this.
We need to enable discovery whether or not it is supported though.

> >  - sta_set_flags
> >  - sta_remove
> >  - flush
> >  - read_sta_data
> 
> I somehow thought that the STA table was global for all virtual
> interfaces, but if that is not the case, adding ifname for these
> functions sounds reasonable. 

Yeah, it currently is. I have a plan to change that though.

> > For not all of the sta functions it is necessary, but since I'm trying
> > to move towards a "stations are per virtual interface" model in mac80211
> > it will probably become necessary, and at least sta_set_flags needs it
> > because of the 802.1x setting.
> 
> OK. I kind of want to declare 0.6.x stable soon which would mean no
> backward incompatible changes to struct wpa_driver_ops, but well, maybe
> we are still far enough from that, so we could just sneak in the simple
> change of adding the extra argument and updating the driver interfaces
> that are included in the hostapd package. It might be good to redesign
> the wpa_driver_ops functions during early 0.7.x work in order to cleanup
> whatever mess is left there (and also to get hostapd and wpa_supplicant
> driver interfaces closer to eachother).

Both would be good. I can see if I can work on doing the change, but I
can't really test any of them except nl80211.

johannes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 828 bytes
Desc: This is a digitally signed message part
Url : http://lists.shmoo.com/pipermail/hostap/attachments/20080603/885af41f/attachment.pgp