wpa_gui-qt4 ui forms and qt4-designer

Jouni Malinen j
Tue Jan 22 21:10:24 PST 2008

On Wed, Jan 23, 2008 at 11:46:23AM +1000, Kel Modderman wrote:

> I want to edit the ui forms of wpa_gui-qt4 to change a couple of things using 
> qt4-designer, but simply opening and saving the form totally rewrites the ui 
> file using 1 space indentation, which causes massive whitespace changes in 
> resulting diff (which i want to send to you) because the files currently use 
> 2 spaces for indentation.

> Do you use qt4-designer or some other tool? Can you offer any advice for this 
> wannabe qt hacker? ;-)

I did use Qt designer (though, from Qt3) to make the original forms.
However, I ended up just doing manual changes after noticing this change
in Qt4.. Or well, it looks like scanresults.ui is in the new format, but
everything else is still use 2 spaces for indentation. I don't know why
they decided to change the indentation, but that sucks..

Originally, there was good reasons to keep the Qt3 and Qt4 version of
wpa_gui as close to each other as possible, but I don't think that that
is the case anymore. Consequently, it sounds reasonable to change these
files to use whatever format Qt4 designer is using.

Feel free to send me diffs in two parts where the first one is just the
change in indentation (save the file as-is in Qt4 designer) and the
second part is the actual change in the UI. I would assume I can
generate the first part easily myself, but just in case there are
differences in the designer versions we use, it is probably better if
you include that onem too.

Jouni Malinen                                            PGP id EFC895FA

More information about the Hostap mailing list