[PATCH] nl80211 driver: fix beacon interval setting

Jouni Malinen j
Wed Apr 9 00:15:56 PDT 2008


On Tue, Apr 08, 2008 at 03:16:19PM +0200, Johannes Berg wrote:
> This removes the hard-coded beacon interval setting.

Thanks! Applied.

> To implement multi-BSS support again I really need per-BSS data in the
> nl80211 driver. I can make it work by introducing a per-VLAN/per-BSS
> data hash that hashes from the interface name, but I'd like to avoid
> that. If I were to post a patch for the driver interface that does what
> I need, would you help me adjust all the other drivers?

Using a hash table here sounds like an optimization that is probably not
needed (we do not really have that many BSSes..). driver_test.c has a
simple example that uses a linked list of per-BSS structures and
test_driver_get_bss() function to fetch one based on ifname. I would
expect something similar to work with driver_nl80211.c, too.

I'm not completely against providing explicit support for per-BSS data
as a private, driver wrapper specific pointer, but 0.6.x branch is
getting to the point where backwards incompatible changes to the driver
wrapper API are not really desired.. This can easily be cleaned
up/optimized in future versions, if needed.


PS.

jkmaline at cc.hut.fi address does not reach me anymore. Please use j at w1.fi
in the future.

-- 
Jouni Malinen                                            PGP id EFC895FA



More information about the Hostap mailing list