[PATCH] expanded dbus control interface functionality and cleanups

Jouni Malinen jkmaline
Mon Aug 21 20:34:50 PDT 2006

On Mon, Aug 21, 2006 at 03:36:40PM -0400, Dan Williams wrote:

> Support a somewhat usable spread of commands, and clean up some D-Bus
> API stuff.

> - Move to abstract object paths for interfaces, rather than using the
> interface's name, which can change, as part of the object path.  This
> requires an additional field in struct wpa_supplicant because I don't
> want to write my own out-of-band hash table code to map object paths to
> interface structures.  No drivers are supposed to use struct
> wpa_supplicant anyway, so there shouldn't be ABI issues.

Yes, that is fine. Anyway, there are no ABI issues inside wpa_supplicant
because there is no requirement on interfaces/structures being _binary_
compatible, i.e., it is acceptable to change structures as long as
recompilation is enough and source level compatibility is maintained on
"supported interfaces" (which is not very well defined, but includes at
least the driver, TLS/crypto, l2_packet, and ctrl_iface backend

> Patch is fairly large and wouldn't make it past moderation; grab it
> here:
> http://people.redhat.com/dcbw/dbus-ctrl-iface-2.patch

Thanks! Applied with some cleanup and couple of bug fixes (always
verify that wpa_zalloc returns !=NULL before dereferencing the pointer;
do not leak memory on realloc error path).

Jouni Malinen                                            PGP id EFC895FA

More information about the Hostap mailing list