[PATCH] linking wpa supplicant sm with hostapd

[Jouni Malinen]

On Wed, Sep 21, 2005 at 11:06:30AM +0200, Leonardo Maccari wrote:

> that's an easy way, but wouldn't it be better to have the names of
> functions and files respecting also which side they belong to
> (supplicant/authenticator)?

If it were that simple in all cases, yes, but.. Number of files and
functions are shared or have been moved around.

> > I would assume you mean to wpa_common.h, not .c.. Yes, that would be

> yes.

> If I want to link wpa.c from wpa_supplicant into hostapd I cannot just
> add the object into the makefile becouse there are double definitions
> with wpa.c in hostapd code. 

Moving those to a header file would not resolve linking issues, so if
these are variables and/or functions that are defined in both files, you
actually have to be meaning both wpa_common.h and .c ;-)

> > One thing to note here is that I'm trying to start stabilizing 0.4.x
> > branch soon, so this kind of moving code from one place to other is
> > going to become less desired before a separate branch for 0.4.x is
> > created. In addition, I would like to delay making the new branch as
> > long as possible in order to avoid having to maintain two branches that
> > are still under active development.
> 
> this sounds like "do it now or wait a lot" :)

Actually, it sounds more like large changes are already too late for
0.4.x to me.. I can consider accepting smaller changes to 0.4.x, but
larger ones should wait for 0.5.x unless they are needed for fixing
something in the current feature set. I'll create a branch for 0.4.x
when there is enough need for it, but like I said, I would rather do
this later than sooner to avoid having to merge lot of changes between
the branches.

-- 
Jouni Malinen                                            PGP id EFC895FA