[PATCH] linking wpa supplicant sm with hostapd

[Jouni Malinen]

On Tue, Sep 20, 2005 at 12:23:02PM +0200, Leonardo Maccari wrote:

> since in hostapd code pmksa_cache_add is the only not static pmksa_cache*
> function when I try to import wpa.c from supplicant to authenticator it
> conflicts. is there a reason for it not to be static? if there is a reason
> I add a few patches for changing its name in wpa_supplicant code (against
> cvs version).

It needs to be callable from other files, so in that sense, yes, it
cannot be static. I don't link chaning just pmksa_cache_add() while
leaving other functions using their current names. Looks like this could
be easier to resolve on the hostapd side either by renaming the
pmksa_cache_() functions or maybe just adding another function as a
wrapper for pmksa_cache_add() and making this conflicting function
static.

> for the same reason, is it possible to move common wpa definitions out of
> wpa.c (in both branches) and move them to something like wpa_common.c?
> 
> for example: 
> #define WPA_REPLAY_COUNTER_LEN 8

I would assume you mean to wpa_common.h, not .c.. Yes, that would be
possible. I was just cleaning up wpa_supplicant by moving wpa.c-specific
defines away from wpa.h, but if there is a good reason to share these
with hostapd, using a common header file would be fine.

One thing to note here is that I'm trying to start stabilizing 0.4.x
branch soon, so this kind of moving code from one place to other is
going to become less desired before a separate branch for 0.4.x is
created. In addition, I would like to delay making the new branch as
long as possible in order to avoid having to maintain two branches that
are still under active development.

-- 
Jouni Malinen                                            PGP id EFC895FA