Hostap 0.0.2 ?

[Pavel Roskin]

On Tue, 29 Apr 2003, Jouni Malinen wrote:

> I try not to keep any strict timetables for driver releases (enough
> deadlines in other projects anyway ;-), but I hope to get 0.0.2 out
> relatively soon. In fact, current CVS snapshot would be more or less OK
> as v0.0.2. I wanted to wait at least couple of days after the changes I
> did last weekend to allow some more testing for them. In other words,
> the more positive testing reports of the current CVS version I hear, the
> faster the next release is going to happen..

The CVS driver is working for me (hostap_cs and hostap_plx).  Scanning is
OK, by the way.  But I'd like to fix some parts that I touched after 0.0.1
release.

hostap.conf is not installed on systems with 2.5.x kernels.  The solution 
is to create a separate target install_conf and share it between 
install_2.5 and install_pccard.

While at that, I have also fixed all cases of calling "make" in makefiles,
replacing them with $(MAKE).  The reasons are explained in the GNU make
manual ("info make").

PRISM2_NON_VOLATILE_DOWNLOAD should be made more visible.  Either it 
should be enabled when PRISM2_DOWNLOAD_SUPPORT is enabled, or should 
appear in driver/modules/hostap_config.h.

There has been a report of the secondary firmware being killed, and the
person who reported it didn't know whether prism2_srec was current of not.

Either we should bump the number for PRISM2_IOCTL_DOWNLOAD, or there 
should be a warning next to the PRISM2_NON_VOLATILE_DOWNLOAD option.  The 
attached patch implements the later approach.

Minor stuff not in the patch, just in case you are not aware.  I can 
provide more information if you consider the issue serious.

Changing mode from Ad-Hoc to Master doesn't enable beacons on 1.5.6 
firmware.  The card pretends to be in the Master mode, but it's not 
sending any beacons.  Calling local->func->reset_port(dev) twice instead 
of once in prism2_ioctl_siwmode() fixes the problem, but I'm not sure it's 
the right approach.

Useless information like "Link Quality" is displayed by iwconfig in the
Master mode.  Maybe it's better not to confuse users by "Link Quality"  
being zero.  But it may be hard to disable printing quality without
suppressing the rest of the data returned by hostap_get_wireless_stats().

-- 
Regards,
Pavel Roskin
-------------- next part --------------
--- Makefile
+++ Makefile
@@ -110,8 +110,8 @@
 		echo "*** Can't build for 2.5 with a non-2.5 source!"; \
 		exit 1; \
 	fi
-	make -C $(KERNEL_PATH) SUBDIRS=$(PWD)/driver/modules modules
-	make 2.5_install_info
+	$(MAKE) -C $(KERNEL_PATH) SUBDIRS=$(PWD)/driver/modules modules
+	$(MAKE) 2.5_install_info
 
 pccard:	$(MSRC)/$(MODULE_CS) hostap crypt install_info
 plx:	$(MSRC)/$(MODULE_PLX) hostap crypt install_info
@@ -168,8 +168,8 @@
 		exit 1; \
 	fi
 
-install_2.5:
-	make install_check
+install_2.5: install_conf
+	$(MAKE) install_check
 	@echo "*** Copying modules to: $(MODPATH)/kernel/drivers/net/wireless"
 	mkdir -p $(MODPATH)/kernel/drivers/net/wireless
 	cp $(MSRC)/*.ko $(MODPATH)/kernel/drivers/net/wireless
@@ -190,13 +190,15 @@
 	mkdir -p $(MODPATH_PCI)
 	cp -f $(MSRC)/hostap_crypt*.o $(MODPATH_PCI)
 
-install_pccard: install_check install_crypt install_hostap
+install_pccard: install_check install_crypt install_hostap install_conf
 	@echo "Installing $(MODULE_CS) to $(MODPATH_CS)"
 	mkdir -p $(MODPATH_CS)
 	cp -f $(MSRC)/$(MODULE_CS) $(MODPATH_CS)
 ifndef DESTDIR
 	/sbin/depmod -ae
 endif
+
+install_conf:
 	@if [ ! -r $(DESTDIR)/etc/pcmcia/hostap_cs.conf ]; then \
 		echo "Installing $(DESTDIR)/etc/pcmcia/hostap_cs.conf"; \
 		cp -f driver/etc/hostap_cs.conf $(DESTDIR)/etc/pcmcia/hostap_cs.conf; \
--- driver/modules/hostap_config.h
+++ driver/modules/hostap_config.h
@@ -44,6 +44,12 @@
 /* Include code for downloading firmware images. */
 /* #define PRISM2_DOWNLOAD_SUPPORT */
 
+/* Allow writing firmware images into flash.  Before you enable this option,
+ * you should make absolutely sure that you are using prism2_srec utility
+ * that comes with THIS version of the driver!  Search and remove all old
+ * versions of prism2_srec NOW - they will damage your card. */
+/* #define PRISM2_NON_VOLATILE_DOWNLOAD */
+
 /* Allow kernel configuration to enable download support. */
 #if !defined(PRISM2_DOWNLOAD_SUPPORT) && defined(CONFIG_HOSTAP_FIRMWARE)
 #define PRISM2_DOWNLOAD_SUPPORT