--mp3 fails for HLS (+Shoutcast) liveradio streams (is already FIXED!)

Vangelis forthnet northmedia1 at the.forthnet.gr
Fri Dec 19 19:55:01 PST 2014


 Hello dinkypumpkin!

 While I was experimenting with my patched get_iplayer-gd1caff0.pl
I mentioned in my other thread:

http://lists.infradead.org/pipermail/get_iplayer/2014-December/006999.html

I noticed at some point that the post-download conversion of hlsaac &
shoutcastaac liveradiomodes to mp3 via the use of the --(aac)mp3 switch 
fails;
the reason it fails is that GiP is instructing FFmpeg to place the MP3 
transcode
inside an MP4 container (this is still compatible) but with an .m4a file 
extension.
I was just ready to post about it, when I saw in the Git repo your latest 
commit:
"Enable --aactomp3 with HLS" which cures this!
Many thanks for catching & fixing it; in fact, I have modified your fix to:

- if ( ! $opt->{raw} && $mode =~ /^flashaac/ ) {
+ if ( ! $opt->{raw} && $mode =~ /^(flash|hls|shoutcast)aac/ ) {

to include shoutcastaac modes,too!
(Apologies for bringing this up again, but would you consider
on-the-fly transcoding to MP3 for hls(/shoutcast)liveradiomodes
if --mp3 is employed? - I do not possess the coding skills to do it meself).

Festive cheers!
V. 




More information about the get_iplayer mailing list