rtmpdump 2.2d different 'swfVfy requires an argument' text

Stuart Henderson stu at spacehopper.org
Thu May 27 19:07:22 EDT 2010


first off, thanks for picking up get_iplayer.

rtmpdump 2.2d uses different text in its error when you try and
use swfVfy without an argument, so the regex test fails.

$ rtmpdump --swfVfy 2>&1 | head -3 
RTMPDump v2.2d
(c) 2010 Andrej Stepanchuk, Howard Chu, The Flvstreamer Team; license: GPL
rtmpdump: option requires an argument -- swfVfy

here's a diff which makes things a bit more robust, it could do
with checking against older rtmpdump if someone has a copy handy.

--- get_iplayer.orig	Thu May 27 23:50:37 2010
+++ get_iplayer	Thu May 27 23:59:46 2010
@@ -8004,8 +8004,8 @@ sub get {
 	}
 
 	# flvstreamer version detection e.g. 'FLVStreamer v1.8a'
-	my $rtmpver = `"$bin->{flvstreamer}" --swfVfy 2>&1`;
-	if ( $rtmpver =~ /option .--swfVfy. requires an argument/ ) {
+	my $rtmpver = `"$bin->{flvstreamer}" --help 2>&1`;
+	if ( $rtmpver =~ /swfVfy/ ) {
 		$swfarg = "--swfVfy";
 	} else {
 		main::logger "WARNING: Your version of flvstreamer/rtmpdump does not support SWF Verification\n";



More information about the get_iplayer mailing list