[bmap-tools] [PATCH 03/16] BmapCreate: fix bmap file format version

Artem Bityutskiy dedekind1 at gmail.com
Mon Nov 4 03:05:23 EST 2013


From: Artem Bityutskiy <artem.bityutskiy at intel.com>

By a mistake, I've made bmap file format version to be 1.4, while is should
really have been 2.0, because there were incompatible changes. Fix this.

Change-Id: If2618db2c12b82f64e1f813e72a2786efdf4d3d5
Signed-off-by: Artem Bityutskiy <artem.bityutskiy at intel.com>
---
 bmaptools/BmapCreate.py | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/bmaptools/BmapCreate.py b/bmaptools/BmapCreate.py
index e1a84c1..2cb7c06 100644
--- a/bmaptools/BmapCreate.py
+++ b/bmaptools/BmapCreate.py
@@ -49,11 +49,16 @@ from bmaptools import Fiemap
 # The bmap format version we generate.
 #
 # Changelog:
-# o 1.3 -> 1.4:
+# o 1.3 -> 2.0:
 #   Support SHA256 and SHA512 checksums, in 1.3 only SHA1 was supported.
 #   "BmapFileChecksum" is used instead of "BmapFileSHA1", and "chksum="
-#   attribute is used instead "sha1=". Introduced "ChecksumType" tag.
-SUPPORTED_BMAP_VERSION = "1.4"
+#   attribute is used instead "sha1=". Introduced "ChecksumType" tag. This is
+#   an incompatible change.
+#   Note, bmap format 1.4 is identical to 2.0. Version 1.4 was a mistake,
+#   instead of incrementing the major version number, we incremented minor
+#   version number. Unfortunately, the mistake slipped into bmap-tools version
+#   3.0, and was only fixed in bmap-tools v3.1.
+SUPPORTED_BMAP_VERSION = "2.0"
 
 _BMAP_START_TEMPLATE = \
 """<?xml version="1.0" ?>
-- 
1.8.1.4




More information about the Bmap-tools mailing list