[PATCH 4/4] USB: typec: Add STUSB160x driver

Sascha Hauer s.hauer at pengutronix.de
Mon Apr 20 04:30:55 PDT 2026


On Mon, Apr 20, 2026 at 01:14:51PM +0200, Ahmad Fatoum wrote:
> Hi,
> 
> On 4/20/26 11:02 AM, Sascha Hauer wrote:
> > --- /dev/null
> > +++ b/drivers/usb/typec/stusb160x.c
> > @@ -0,0 +1,572 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +// SPDX-Comment: Origin-URL: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/usb/typec/stusb160x.c?id=82375469755662b9910a22da14027cbef2bca666/*
> 
> Invalid link. You may want to remove /* at the end.

Missing newline, /* should go to the next line.

> 
> > +	node = of_get_child_by_name(client->dev.of_node, "connector");
> > +	if (!node)
> > +		return -ENODEV;
> 
> Add extra error message here or return another error code that's not
> silently swallowed up?

Yes.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the barebox mailing list