[PATCH 06/11] boards: enclustra-sa2: read MAC address from EEPROM

[Sascha Hauer]

Hi David,

On Wed, Sep 17, 2025 at 05:22:09PM +0200, David Picard wrote:
> Signed-off-by: David Picard <david.picard at clermont.in2p3.fr>
> ---
>  arch/arm/boards/enclustra-sa2/Makefile    |   2 +-
>  arch/arm/boards/enclustra-sa2/atsha204a.c | 436 ++++++++++++++++++++++++++++++
>  arch/arm/boards/enclustra-sa2/atsha204a.h |  19 ++
>  arch/arm/boards/enclustra-sa2/board.c     |  51 +++-
>  arch/arm/boards/enclustra-sa2/crc16.c     |  65 +++++
>  arch/arm/boards/enclustra-sa2/crc16.h     |  28 ++
>  arch/arm/mach-socfpga/Kconfig             |   1 +
>  7 files changed, 598 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/boards/enclustra-sa2/Makefile b/arch/arm/boards/enclustra-sa2/Makefile
> index 8c927fe291a6b3eb20a32a2db96c73f231ab4697..1448ea1266aa24a5b0404cb6379f8c2d76573079 100644
> --- a/arch/arm/boards/enclustra-sa2/Makefile
> +++ b/arch/arm/boards/enclustra-sa2/Makefile
> @@ -1,2 +1,2 @@
> -obj-y += lowlevel.o board.o
> +obj-y += lowlevel.o board.o atsha204a.o crc16.o
>  pbl-y += lowlevel.o
> diff --git a/arch/arm/boards/enclustra-sa2/atsha204a.c b/arch/arm/boards/enclustra-sa2/atsha204a.c
> new file mode 100644
> index 0000000000000000000000000000000000000000..3f445de06e73c5bdf27d2d0fc81dc6d939d5cd17
> --- /dev/null
> +++ b/arch/arm/boards/enclustra-sa2/atsha204a.c

This looks like you should rather adopt the Linux driver from
drivers/crypto/atmel-sha204a.c.

Maybe you can even create a NVMEM cell for the MAC address and then no
board specific code would be needed for retrieving the MAC.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |