[PATCH v2 1/3] video: simplefb-client: switch to dev_get_resource
Ivaylo Ivanov
ivo.ivanov.ivanov1 at gmail.com
Tue Sep 2 07:00:04 PDT 2025
If the framebuffer memory resource resides in ram, it has already
been requested and mapped, so only get the resource to avoid
requesting a busy resource. This is also the approach for linux.
While at it, use IOMEM for mem->start and drop an unnecessary newline.
Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1 at gmail.com>
Reviewed-by: Ahmad Fatoum <a.fatoum at pengutronix.de>
---
drivers/video/simplefb-client.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/video/simplefb-client.c b/drivers/video/simplefb-client.c
index dafec617..41ad8ffa 100644
--- a/drivers/video/simplefb-client.c
+++ b/drivers/video/simplefb-client.c
@@ -96,7 +96,7 @@ static int simplefb_probe(struct device *dev)
if (ret)
return ret;
- mem = dev_request_mem_resource(dev, 0);
+ mem = dev_get_resource(dev, IORESOURCE_MEM, 0);
if (IS_ERR(mem)) {
dev_err(dev, "No memory resource\n");
return PTR_ERR(mem);
@@ -116,10 +116,9 @@ static int simplefb_probe(struct device *dev)
info->blue = params.format->blue;
info->transp = params.format->transp;
- info->screen_base = (void *)mem->start;
+ info->screen_base = IOMEM(mem->start);
info->screen_size = resource_size(mem);
-
info->fbops = &simplefb_ops;
info->dev.parent = dev;
--
2.43.0
More information about the barebox
mailing list